• Clemens Backes's avatar
    [wasm] Avoid code modifications during code freeing · d38ea7d9
    Clemens Backes authored
    Code freeing can happen at any point in time where a GC might be
    triggered. Hence it's difficult to ensure that no other
    {CodeSpaceWriteScope} is already open at that point. The way these scope
    objects are implemented forbids multiple scopes for different modules
    though.
    To solve this, this CL just avoids the code zapping in
    {WasmCodeAllocator::FreeCode}, which is the only place that actually
    writes to the code space. Without this, we do not need the
    {CodeSpaceWriteScope} in {NativeModule::FreeCode} any more.
    
    R=jkummerow@chromium.org
    
    Bug: v8:11974
    Change-Id: I1f01979e1eaea6c311c9ad568d605aabeef3bfc4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3081522
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76174}
    d38ea7d9
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...