• Eric Holk's avatar
    [wasm] always allocate memory when guard regions are needed · d31dff84
    Eric Holk authored
    When using trap handlers, memory references do not get any checks inserted. This
    means there is no check for a null memory as happens when the memory size is
    0. Normally this would be correctly caught as an out of bounds access, since the
    low memory addresses are not normally mapped. However, if they were mapped for
    some reason, we would not catch the out of bounds access.
    
    The fix is to ensure WebAssembly instances always have a guard region even if
    the memory is size 0.
    
    This is a rewrite of 5e76ff5a
    
    Note that this can lead to a large amount of unnecessary address space usage,
    so we share a single reservation for empty array buffers.
    
    Bug: chromium:769637
    
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: Ia8e84be6d595e347d3d342959f2c374db1a3f683
    Reviewed-on: https://chromium-review.googlesource.com/702657Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Eric Holk <eholk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52163}
    d31dff84
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...