• Jakob Gruber's avatar
    [compiler] Allocate in a temporary zone inside ComputeLoopState · d267c337
    Jakob Gruber authored
    Even in the most basic case (the task queue only ever contains a single
    element), this function triggers ~4KB in zone allocations. These
    allocations are basically lost and can never be reused. Avoid this by
    allocating inside a new temporary zone that is only alive during the
    ComputeLoopState function call.
    
    This reduces allocation size for the zone used during load elimination
    from ~30KB to ~15KB when compiling a trivial for-loop example.
    
    An alternative solution would be to switch to something similar to
    SmallVector (which uses a statically-sized stack storage before
    switching to heap allocations), but based on zones instead of malloc.
    
    Bug: v8:9427,v8:6150
    Change-Id: Ic25abe6d48ac718c9ced2f9ef581f244030980fa
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1714869
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62883}
    d267c337
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...