• jgruber's avatar
    Handle missing context when getting frame details · d2528080
    jgruber authored
    This bug was triggered by a very specific combination:
    
    * A context-allocated variable at script scope.
    * OSR optimization.
    * A scheduled breakpoint, which triggers at stack checks.
    
    Stack checks differ from other possible breakpoint locations in that
    the context (among other things) may be in a register and not on the
    stack, making it impossible to recover during deoptimization. The
    frame_inspector then returns undefined when asked for the context.
    
    In GetFrameDetails, handle this case by omitting all context-allocated
    variables.
    
    BUG=v8:5279
    
    Review-Url: https://codereview.chromium.org/2245603002
    Cr-Commit-Position: refs/heads/master@{#38611}
    d2528080
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...