• Ng Zhi An's avatar
    Fix loads and stores of s128 for arm · d1f87915
    Ng Zhi An authored
    The vst1 and vld1 instruction does a post-increment access. What we
    intend is the usual access at (base+offset). This change adds a helper
    function that is called for load and stores of s128, which emits the add
    instruction to do base+offset, and then change the addressing mode of
    the load/store to Operand2_R, which generates the variant of vld1/vst1
    without the offset register. This is similar to how kSimd128 values are
    loaded/stored in VisitUnalignedLoad and VisitUnalignedStore.
    
    We also remove kSimd128 cases from UnalignedLoad and UnalignedStore,
    since it is supported (see A3.2.1 Unaligned Data Access, ARM DDI
    0406C.d)
    
    Bug: v8:9746
    Bug: v8:9748
    Change-Id: I60b987ac58a5eaacd498a940625163484a3dc2db
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834771Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64229}
    d1f87915
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...