• Clemens Hammacher's avatar
    [wasm] [interpreter] Fix GC issue · d1b4d4fe
    Clemens Hammacher authored
    Make sure that we call the destructors on all embedded object by
    replacing the WasmInterpreterInternals::Delete method by an actual
    destructor. This way, the compiler automatically calls destructors on
    all embedded objects, in particular the IdentityMap in the CodeMap.
    
    This change also requires to release managed objects *before*
    tearing down the heap, because the wasm interpreter, referenced via
    Managed<>, contains global handles. When those are destroyed, the
    isolate still needs to be intact.
    
    Drive-by: Fix include guard in managed.h.
    
    R=ahaas@chromium.org, ulan@chromium.org, mvstanton@chromium.org
    BUG=v8:5822
    
    Change-Id: I9a067f037e013c84e4d697a1e913b27c683bb529
    Reviewed-on: https://chromium-review.googlesource.com/466187Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44368}
    d1b4d4fe
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...