• Shu-yu Guo's avatar
    [compiler] Fix typing JSLoadNamed of private brands · d19a707d
    Shu-yu Guo authored
    Private method loads are compiled to a named load of a private brand,
    which always loads a BlockContext. This BlockContext holds the private
    methods common to all instances of a class. TurboFan currently considers
    JSLoadNamed to be of Type::NonInternal(). Private methods break this
    assumption, since BlockContext is of Type::OtherInternal().
    
    This CL changes the typing of JSLoadNamed of private brands to be
    Type::OtherInternal().
    
    Bug: v8:12500
    Change-Id: I91f39747bf9422bd419d299f44152f567d8be8db
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3351167Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78431}
    d19a707d
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...