• mike's avatar
    [parser] Relex restriction on reserved words · d0c65f93
    mike authored
    Some IdentifierNames are only included in the set of FutureReservedWords
    for strict mode code. Outside of strict mode, these IdentifierNames may
    be used as Identifiers. Notably, this includes their use as
    BindingIdentifiers in LexicalBindings.
    
    From ES2015 12.1.1 Static Semantics: Early Errors (Identifiers):
    
    > It is a Syntax Error if this phrase is contained in strict mode code
    > and the StringValue of IdentifierName is: "implements", "interface",
    > "let", "package", "private", "protected", "public", "static", or
    > "yield".
    
    http://www.ecma-international.org/ecma-262/6.0/#sec-identifiers-static-semantics-early-errors
    
    Due to a error in its heuristic for disambiguating the `let` token, V8
    does not currently allow any of the strict-mode-only FutureReservedWords
    to be used as a BindingIdentifier outside of strict mode.
    
    Update V8's heuristic for disambiguating the `let` keyword to account
    for strict mode, enabling these IdentifierNames to be used
    
    BUG=v8:4918
    LOG=N
    R=adamk@chromium.org
    
    Review-Url: https://codereview.chromium.org/1891453005
    Cr-Commit-Position: refs/heads/master@{#36296}
    d0c65f93
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...