• Georg Neis's avatar
    Reland "[compiler] Directly read PropertyCells" · cf7cba8d
    Georg Neis authored
    This reverts commit 87df0b7e (thus
    relands 42cd9eb7), with fixes for
    the discovered issues.
    
    Original change's description:
    > Revert "[compiler] Directly read PropertyCells"
    >
    > This reverts commit 42cd9eb7.
    >
    > Reason for revert: Clusterfuzz issues, e.g.
    > https://bugs.chromium.org/p/chromium/issues/detail?id=1176318
    >
    > Original change's description:
    > > [compiler] Directly read PropertyCells
    > >
    > > Main changes:
    > >
    > > - Introduce a new broker data kind kBackgroundSerialized for objects
    > >   that can be serialized in the background (when direct reads are on).
    > >   (I'm planning to remove kPossiblyBackgroundSerialized in a followup,
    > >   in favor of a dynamic choice of kSerialized or kBackgroundSerialized).
    > > - Make PropertyCell use that new kind.
    > > - Introduce a bottleneck in runtime code for changes to PropertyCells
    > >   and make sure that a certain protocol is followed that allows
    > >   concurrent reads from the background thread.
    > > - Improve interface of PropertyCell in various ways.
    > >
    > > Bug: v8:7790
    > > Change-Id: If3d7926c3b894808811348b4b2bed153f5c06897
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2661462
    > > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > > Commit-Queue: Georg Neis <neis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#72586}
    >
    > TBR=ulan@chromium.org,neis@chromium.org,verwaest@chromium.org,nicohartmann@chromium.org
    >
    > Change-Id: Id04145760c49fa379bc5a3fc16eba664025a9180
    > Bug: v8:7790
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2685125
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#72619}
    
    Bug: v8:7790, chromium:1176509, chromium:1176318, chromium:1176504
    Change-Id: Icaf285912bb948432a4a2d599cd174f6a5aa296e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2685166Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#72697}
    cf7cba8d
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...