• Joyee Cheung's avatar
    [ic] name Set/Define/Store property operations more consistently pt.2 · cf5ce194
    Joyee Cheung authored
    As a follow-up of
    https://chromium-review.googlesource.com/c/v8/v8/+/3481475,
    this renames a few more operations related to property stores to keep
    them consistent and adds comments to explain about what they do.
    
    Summary of the renamed identifiers:
    
    - SetPropertyInLiteral -> CreateDataProperty: this implements
      [[CreateDataProperty]] in the spec which does [[DefineOwnProperty]]
      instead of [[Set]], so rename for clarity.
    - IsStoreIC(), IsStoreICKind() -> IsSetNamedIC(), IsSetNamedICKind():
      these only check whether the feedback kind is kSetNamedSloppy or
      kSetNamedStrict, so the scope can be narrowed.
    - StoreMode::kOrdinary -> StoreMode::kSet: this implements [[Set]]
      in the spec and is used by both KeyedStoreIC and
      StoreIC to set the properties when there is no feedback.
    - StoreMode::kInLiteral -> StoreMode::kDefineKeyedOwnInLiteral:
      this implements [[CreateDataProperty]] while expecting the receiver
      to be a JSObject created by us (the `InLiteral` part). Prepend
      `DefineKeyedOwn` to it so that it's more aligned with other
      StoreModes - it should be possible to just merge this into the
      more generic StoreMode::kDefineKeyedOwn later.
    - KeyedStoreGenericAssembler::SetProperty ->
      KeyedStoreGenericAssembler::StoreProperty: these helpers are used by
      both define and set operations, distinguished with the StoreMode,
      so rename it to the more generic StoreProperty.
    
    Bug: v8:12548
    Change-Id: Iccef673c1dc707bbdbf010f02f7db1e9ec32b3e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557690Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#79694}
    cf5ce194
Name
Last commit
Last update
..
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
accessor-assembler.cc Loading commit data...
accessor-assembler.h Loading commit data...
binary-op-assembler.cc Loading commit data...
binary-op-assembler.h Loading commit data...
call-optimization.cc Loading commit data...
call-optimization.h Loading commit data...
handler-configuration-inl.h Loading commit data...
handler-configuration.cc Loading commit data...
handler-configuration.h Loading commit data...
handler-configuration.tq Loading commit data...
ic-inl.h Loading commit data...
ic-stats.cc Loading commit data...
ic-stats.h Loading commit data...
ic.cc Loading commit data...
ic.h Loading commit data...
keyed-store-generic.cc Loading commit data...
keyed-store-generic.h Loading commit data...
stub-cache.cc Loading commit data...
stub-cache.h Loading commit data...
unary-op-assembler.cc Loading commit data...
unary-op-assembler.h Loading commit data...