• Joyee Cheung's avatar
    [ic] name Set/Define/Store property operations more consistently pt.2 · cf5ce194
    Joyee Cheung authored
    As a follow-up of
    https://chromium-review.googlesource.com/c/v8/v8/+/3481475,
    this renames a few more operations related to property stores to keep
    them consistent and adds comments to explain about what they do.
    
    Summary of the renamed identifiers:
    
    - SetPropertyInLiteral -> CreateDataProperty: this implements
      [[CreateDataProperty]] in the spec which does [[DefineOwnProperty]]
      instead of [[Set]], so rename for clarity.
    - IsStoreIC(), IsStoreICKind() -> IsSetNamedIC(), IsSetNamedICKind():
      these only check whether the feedback kind is kSetNamedSloppy or
      kSetNamedStrict, so the scope can be narrowed.
    - StoreMode::kOrdinary -> StoreMode::kSet: this implements [[Set]]
      in the spec and is used by both KeyedStoreIC and
      StoreIC to set the properties when there is no feedback.
    - StoreMode::kInLiteral -> StoreMode::kDefineKeyedOwnInLiteral:
      this implements [[CreateDataProperty]] while expecting the receiver
      to be a JSObject created by us (the `InLiteral` part). Prepend
      `DefineKeyedOwn` to it so that it's more aligned with other
      StoreModes - it should be possible to just merge this into the
      more generic StoreMode::kDefineKeyedOwn later.
    - KeyedStoreGenericAssembler::SetProperty ->
      KeyedStoreGenericAssembler::StoreProperty: these helpers are used by
      both define and set operations, distinguished with the StoreMode,
      so rename it to the more generic StoreProperty.
    
    Bug: v8:12548
    Change-Id: Iccef673c1dc707bbdbf010f02f7db1e9ec32b3e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557690Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#79694}
    cf5ce194
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...