• Joyee Cheung's avatar
    [ic] name Set/Define/Store property operations more consistently pt.2 · cf5ce194
    Joyee Cheung authored
    As a follow-up of
    https://chromium-review.googlesource.com/c/v8/v8/+/3481475,
    this renames a few more operations related to property stores to keep
    them consistent and adds comments to explain about what they do.
    
    Summary of the renamed identifiers:
    
    - SetPropertyInLiteral -> CreateDataProperty: this implements
      [[CreateDataProperty]] in the spec which does [[DefineOwnProperty]]
      instead of [[Set]], so rename for clarity.
    - IsStoreIC(), IsStoreICKind() -> IsSetNamedIC(), IsSetNamedICKind():
      these only check whether the feedback kind is kSetNamedSloppy or
      kSetNamedStrict, so the scope can be narrowed.
    - StoreMode::kOrdinary -> StoreMode::kSet: this implements [[Set]]
      in the spec and is used by both KeyedStoreIC and
      StoreIC to set the properties when there is no feedback.
    - StoreMode::kInLiteral -> StoreMode::kDefineKeyedOwnInLiteral:
      this implements [[CreateDataProperty]] while expecting the receiver
      to be a JSObject created by us (the `InLiteral` part). Prepend
      `DefineKeyedOwn` to it so that it's more aligned with other
      StoreModes - it should be possible to just merge this into the
      more generic StoreMode::kDefineKeyedOwn later.
    - KeyedStoreGenericAssembler::SetProperty ->
      KeyedStoreGenericAssembler::StoreProperty: these helpers are used by
      both define and set operations, distinguished with the StoreMode,
      so rename it to the more generic StoreProperty.
    
    Bug: v8:12548
    Change-Id: Iccef673c1dc707bbdbf010f02f7db1e9ec32b3e4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3557690Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#79694}
    cf5ce194
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...