• Omer Katz's avatar
    cppgc: Fix crash when finalizing incremental GC. · 8ba4bcea
    Omer Katz authored
    The gc_in_progress flag was reset to false only after sweeping was done.
    As a result, if we call CollectGarbage during an incremental GC and
    after marking has finished, the we will observe that a gc is still in
    progress but will not have a marker and crash.
    
    The immediate solution is to move resetting the gc_in_progress flag such
    that it indicates whether we didn't have the atomic pause yet. That
    means we could have gc_in_progress==false and incremental sweeping still
    running, which semantically negates the meaning of gc_in_progress.
    
    Observing that gc_in_progress essentially becomes equivalent to having a
    marker, this CL removes the gc_in_progress flag and replaces checks on
    it with checks on marker.
    
    Bug: chromium:1156170
    Change-Id: Ic4b441ec248b5f7e222e988870e46d5166dd4dcc
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584875
    Commit-Queue: Omer Katz <omerkatz@chromium.org>
    Auto-Submit: Omer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71712}
    8ba4bcea
Name
Last commit
Last update
..
allocation.cc Loading commit data...
caged-heap-local-data.cc Loading commit data...
caged-heap.cc Loading commit data...
caged-heap.h Loading commit data...
compaction-worklists.cc Loading commit data...
compaction-worklists.h Loading commit data...
compactor.cc Loading commit data...
compactor.h Loading commit data...
concurrent-marker.cc Loading commit data...
concurrent-marker.h Loading commit data...
default-platform.cc Loading commit data...
free-list.cc Loading commit data...
free-list.h Loading commit data...
garbage-collector.h Loading commit data...
gc-info-table.cc Loading commit data...
gc-info-table.h Loading commit data...
gc-info.cc Loading commit data...
gc-invoker.cc Loading commit data...
gc-invoker.h Loading commit data...
globals.h Loading commit data...
heap-base.cc Loading commit data...
heap-base.h Loading commit data...
heap-growing.cc Loading commit data...
heap-growing.h Loading commit data...
heap-object-header.cc Loading commit data...
heap-object-header.h Loading commit data...
heap-page.cc Loading commit data...
heap-page.h Loading commit data...
heap-space.cc Loading commit data...
heap-space.h Loading commit data...
heap-visitor.h Loading commit data...
heap.cc Loading commit data...
heap.h Loading commit data...
incremental-marking-schedule.cc Loading commit data...
incremental-marking-schedule.h Loading commit data...
liveness-broker.cc Loading commit data...
liveness-broker.h Loading commit data...
logging.cc Loading commit data...
marker.cc Loading commit data...
marker.h Loading commit data...
marking-state.cc Loading commit data...
marking-state.h Loading commit data...
marking-verifier.cc Loading commit data...
marking-verifier.h Loading commit data...
marking-visitor.cc Loading commit data...
marking-visitor.h Loading commit data...
marking-worklists.cc Loading commit data...
marking-worklists.h Loading commit data...
name-trait.cc Loading commit data...
object-allocator.cc Loading commit data...
object-allocator.h Loading commit data...
object-start-bitmap.h Loading commit data...
page-memory.cc Loading commit data...
page-memory.h Loading commit data...
persistent-node.cc Loading commit data...
platform.cc Loading commit data...
pointer-policies.cc Loading commit data...
prefinalizer-handler.cc Loading commit data...
prefinalizer-handler.h Loading commit data...
process-heap.cc Loading commit data...
process-heap.h Loading commit data...
raw-heap.cc Loading commit data...
raw-heap.h Loading commit data...
sanitizers.h Loading commit data...
source-location.cc Loading commit data...
stats-collector.cc Loading commit data...
stats-collector.h Loading commit data...
sweeper.cc Loading commit data...
sweeper.h Loading commit data...
task-handle.h Loading commit data...
trace-event.h Loading commit data...
trace-trait.cc Loading commit data...
virtual-memory.cc Loading commit data...
virtual-memory.h Loading commit data...
visitor.cc Loading commit data...
visitor.h Loading commit data...
write-barrier.cc Loading commit data...