• Clemens Backes's avatar
    [wasm][debug] Prefer debug code in tiered down mode · cf382c89
    Clemens Backes authored
    We were still occasionally failing tests because sometimes non-debug
    Liftoff code was published *after* debug Liftoff code. This would
    overwrite the debug code and we would not stop on function entry then.
    This fixes this by only preferring Liftoff code in publishing if it has
    been compiled for debugging.
    As a side effect, this will also prefer TurboFan code which has been
    compiled for debugging (i.e. Liftoff bailed out), but this would only
    happen for experimental features and in this case we will just overwrite
    TurboFan code with TurboFan code, which is fine.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10410
    Change-Id: I6516e9f474f6118f0f0c077e6789f604ca128e74
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144122Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67123}
    cf382c89
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...