• ahaas's avatar
    Revert of [turbofan] Split CodeGenerator::GenerateCode into AssembleCode and... · ce5a46b3
    ahaas authored
    Revert of [turbofan] Split CodeGenerator::GenerateCode into AssembleCode and FinishCodeObject. (patchset #3 id:40001 of https://codereview.chromium.org/2229243003/ )
    
    Reason for revert:
    There is a data race in the initialization of the Isolate::random_number_generator()
    
    Original issue's description:
    > [turbofan] Split CodeGenerator::GenerateCode into AssembleCode and FinishCodeObject.
    >
    > This CL splits CodeGenerator::GenerateCode into two new functions:
    > AssembleCode and FinishCodeObject. AssembleCode does not access or
    > modify the JS heap, which means that AssembleCode can be executed on
    > background threads. FinishCodeObject allocates the generated code object
    > on the JS heap and therefore has to be executed on the main thread.
    >
    > Implementation details:
    > The GenerateCode function has been split just before out-of-line code is
    > assembled. The reason is that code stubs may be generated when
    > out-of-line code is assembled, which potentially allocates these code
    > stubs on the heap.
    >
    > - Parts of initialization of the CodeGenerator has been moved from the
    > constructor to an Initialize function so that we can instantiate an empty
    > CodeGenerator object in PipelineData.
    >
    > R=bmeurer@chromium.org, mstarzinger@chromium.org, titzer@chromium.org
    >
    > Committed: https://crrev.com/03058a2187e32cc4080612181802086527c116a2
    > Cr-Commit-Position: refs/heads/master@{#38604}
    
    TBR=bmeurer@chromium.org,mstarzinger@chromium.org,titzer@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review-Url: https://codereview.chromium.org/2240523003
    Cr-Commit-Position: refs/heads/master@{#38605}
    ce5a46b3
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...