• zhengxing.li's avatar
    [TurboFan] Avoid Gcc compilation fail by Initializing rest_index variable. · ce138669
    zhengxing.li authored
      The CL #38858 (https://codereview.chromium.org/2269293004) removed the parameter assignment code
      in rest_parameter(int* index) function in Class DeclarationScope.
    
      This caused the Gcc compilation fail at the following code in src/compiler/ast-graph-builder.cc, line 576.
      int rest_index;
      Variable* rest_parameter = scope->rest_parameter(&rest_index);
      BuildRestArgumentsArray(rest_parameter, rest_index);
    
      The error message was:
      ../src/compiler/ast-graph-builder.cc: In member function ‘void v8::internal::compiler::AstGraphBuilder::CreateGraphBody(bool)’:
      ../src/compiler/ast-graph-builder.cc:578:54: error: ‘rest_index’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      BuildRestArgumentsArray(rest_parameter, rest_index);
                                                          ^
    
      This CL fixed this issue by intializing rest_index to 0.
    
    BUG=
    
    Review-Url: https://codereview.chromium.org/2270363003
    Cr-Commit-Position: refs/heads/master@{#38863}
    ce138669
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...