• Bill Budge's avatar
    Revert "[turbofan][csa] optimize Smi untagging better" · cdea7999
    Bill Budge authored
    This reverts commit ff22ae80.
    
    Reason for revert: new test fails on UBSAN
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/10831
    
    Original change's description:
    > [turbofan][csa] optimize Smi untagging better
    > 
    > - Introduce new operator variants for signed right-shifts with the
    >   additional information that they always shift out zeros.
    > - Use these new operators for Smi untagging.
    > - Merge left-shifts with a preceding Smi-untagging shift.
    > - Optimize comparisons of Smi-untagging shifts to operate on the
    >   unshifted word.
    > - Optimize 64bit comparisons of values expanded from 32bit to use
    >   a 32bit comparison instead.
    > - Change CodeStubAssembler::UntagSmi to first sign-extend and then
    >   right-shift to enable better address computations for Smi indices.
    > 
    > Bug: v8:9962
    > Change-Id: If91300f365e8f01457aebf0bd43bdf88b305c460
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2135734
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67378}
    
    TBR=neis@chromium.org,tebbi@chromium.org
    
    Change-Id: I2617d7a44e5ae33fd79322d37c8b722c00162d22
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9962
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2165873Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Bill Budge <bbudge@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67380}
    cdea7999
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...