• Peter Marshall's avatar
    [runtime] Fix spec bug in TypedArrayConstruct with mutating iterables. · cc75535d
    Peter Marshall authored
    The spec requires that we use IterableToList, which we skipped for
    some arrays as an optimization. We can't skip this for arrays with
    objects though, because the objects may mutate the array during
    the copying step via valueOf side effects.
    
    Also clean up the implementation to use a runtime function rather
    than a builtin as the helper. Also reverses the result of the helper
    because I think it is a bit more intuitive that way.
    
    Bug: v8:6224
    Change-Id: I9199491abede4479785df6d9068331bc2d6e9c5e
    Reviewed-on: https://chromium-review.googlesource.com/471986Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#44507}
    cc75535d
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...