• Patrick Thier's avatar
    [string] Make String internalization threadsafe for shared strings · cc3c93f1
    Patrick Thier authored
    This CL fixes 2 issues with string internalization when the string table
    is shared:
    1. In-place migration of a string's map to Internalized was done before
       it was sure that the string is going to be internalized (outside the
       critical section). To fix this problem StringTableKey::AsHandle() is
       now split into StringTableKey::PrepareForInsertion(), which is
       invoked outside the critical section and creates a copy if
       necessary, and StringTableKey::GetHandleForInsertion(), which is
       invoked inside the critical section only for string table misses.
       Migration of the map is handled by this method.
    2. TryStringToIndexOrLookupExisting() didn't handle already internalized
       strings. So far this was impossible, as this method was only invoked
       for strings that were checked not to be internalized. However with
       a shared string table, the string could be internalized after the
       checks.
    
    Bug: v8:12007
    Change-Id: I193d6b54dc41360eee47d21cbcaa36d2652d85dd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3368103Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78600}
    cc3c93f1
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...