• Bret Sepulveda's avatar
    profview: Fix leaking state when switching log files. · cb65864d
    Bret Sepulveda authored
    When switching log files, if a function was selected the timeline would
    attempt to draw its ticks and would usually crash. It would also
    preserve the selected section of the timeline.
    
    This patch wipes out the current state when loading a new log file,
    with the exception of the current mode (Summary, Bottom up, etc). As a
    consequence, the timeline size is now calculated in TimelineView.render
    so it will always be drawn at the right size.
    
    Bug: v8:6240
    Change-Id: Ie15dd9b225901c8f4df614444458ae2aeaf74ccc
    Reviewed-on: https://chromium-review.googlesource.com/1186340Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Bret Sepulveda <bsep@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55339}
    cb65864d
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...