• Bruce Dawson's avatar
    Show failure codes in run.py · cad1845a
    Bruce Dawson authored
    If mksnapshot fails then all that is printed is
        "FAILED: gen/v8/embedded.S snapshot_blob.bin"
    and the command line. That complicates the investigation. Printing the
    error code in run.py can help. The printing code handles large negative
    numbers specially so that special Windows failure codes like 0xC0000005
    are recognizable.
    
    This code was tested by adding this early-out to main in mksnapshot.cc.
    
      if (argc < 1000)
        return 0xc0000005;
    
    Bug: Chromium:1095767
    Change-Id: I5dc81d368beaa339f0c519ce1c01bd13cdb18d93
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2249518
    Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68395}
    cad1845a
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...