• Dominik Inführ's avatar
    [heap] Remove sweeping_slot_set_ from MemoryChunk · ca505562
    Dominik Inführ authored
    Since the new space is always empty after a full GC, the old-to-new
    remembered set is also always empty after a full GC. This means we can
    get rid of the sweeping_slot_set_.
    
    This slot set was used to allow the main thread to insert into the
    old-to-new remembered set non-atomically. The sweeping slot set was
    owned by the sweeper, which deletes slots in free memory from it. The
    main thread would start with an empty old-to-new remembered set. After
    sweeping both slot sets are merged again.
    
    The sweeper now needs to behave differently during a GC. When sweeping
    a page during full GC, the sweeper needs to delete old-to-new-slots in
    free memory.
    
    Outside of the GC the sweeper isn't allowed to remove from the
    old-to-new slots anymore. This would race with the main thread that adds
    slots to that remembered set while the sweeper is running. However,
    there should be no recorded slots in free memory. DCHECKing this is
    tricky though, because we would need to synchronize with the main
    thread right-trimming objects and at least String::MakeThin only deletes
    slots after the map release-store.
    
    Bug: v8:12760
    Change-Id: Ic0301851a714e894c3040595f456ab93b5875c81
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3560638Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79713}
    ca505562
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...