• Manos Koukoutos's avatar
    [wasm] Refactor/cleanup DecodeLocals, read_value_type · a4d295ad
    Manos Koukoutos authored
    Changes:
    Cleanup:
    - Make sure read_value_type has the same interface as other
      read_* functions, i.e., returns the decoded value and writes
      the consumed length into a pointer.
    - DecodeLocals is now an instance method.
    - DecodeLocals should fail when given a wrong number of locals.
      Add tests to catch that.
    - Fix a buggy test.
    
    Refactoring in preparation of introducing the 'let'
    instruction as per [wasm-gc]:
    - DecodeLocals does not consume any input and can start from any pc.
    - DecodeLocals gives the option of not appending the decoded
      locals to local_types_.
    - Separate locals initialization from signature.
    
    Bug: v8:7748
    Change-Id: Iaaff87fdb9abe0ddd716484ea3fa87779d2d1a2f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2202992
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67845}
    a4d295ad
Name
Last commit
Last update
..
OWNERS Loading commit data...
test-c-wasm-entry.cc Loading commit data...
test-compilation-cache.cc Loading commit data...
test-gc.cc Loading commit data...
test-grow-memory.cc Loading commit data...
test-jump-table-assembler.cc Loading commit data...
test-liftoff-inspection.cc Loading commit data...
test-run-wasm-64.cc Loading commit data...
test-run-wasm-asmjs.cc Loading commit data...
test-run-wasm-atomics.cc Loading commit data...
test-run-wasm-atomics64.cc Loading commit data...
test-run-wasm-bulk-memory.cc Loading commit data...
test-run-wasm-exceptions.cc Loading commit data...
test-run-wasm-interpreter.cc Loading commit data...
test-run-wasm-js.cc Loading commit data...
test-run-wasm-module.cc Loading commit data...
test-run-wasm-sign-extension.cc Loading commit data...
test-run-wasm-simd-liftoff.cc Loading commit data...
test-run-wasm-simd-scalar-lowering.cc Loading commit data...
test-run-wasm-simd.cc Loading commit data...
test-run-wasm.cc Loading commit data...
test-streaming-compilation.cc Loading commit data...
test-wasm-breakpoints.cc Loading commit data...
test-wasm-codegen.cc Loading commit data...
test-wasm-debug-evaluate.cc Loading commit data...
test-wasm-import-wrapper-cache.cc Loading commit data...
test-wasm-serialization.cc Loading commit data...
test-wasm-shared-engine.cc Loading commit data...
test-wasm-stack.cc Loading commit data...
test-wasm-trap-position.cc Loading commit data...
wasm-atomics-utils.h Loading commit data...
wasm-run-utils.cc Loading commit data...
wasm-run-utils.h Loading commit data...