• Jakob Gruber's avatar
    [regexp] Don't use eats_at_least for backwards loops · c977b65b
    Jakob Gruber authored
    The eats_at_least (EAL) value is applied in forward-directions only.
    Two reasons for that which are relevant to this CL:
    
    - EAL's of neighboring nodes are combined additively, irrespective of
      their read_backward value.
    - EatsAtLeastPropagator::VisitText uses the successor's
      eats_at_least_from_not_start value, which doesn't work properly for
      read_backwards successors (which may end at the start).
    
    A symptom of this bug was that we applied an incorrect EAL of 255
    starting at the initial 'x' of /x(?<=^x{4})/); for subject strings
    shorter than 255 chars, this would result in an incorrect failure
    result.
    
    Bug: v8:11616
    Change-Id: I4b2b1b78f0cea8f59e4beb1037ee46035d83c927
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2807596Reviewed-by: 's avatarSeth Brenith <seth.brenith@microsoft.com>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73848}
    c977b65b
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...