• Santiago Aboy Solanes's avatar
    [turbolizer] Solve off-by-one source position error for non-Wasm · 433ff6b9
    Santiago Aboy Solanes authored
    Wasm has the attribute sourceLineToBytecodePosition and adds the source
    lines via setSourceLineToBytecodePosition in which they are 0-based.
    Non-Wasm doesn't have that attribute and uses insertSourcePositions
    which is 1-based. In non-wasm we are being off by one.
    As a note, the sourcePositionsInRange call in insertSourcePositions
    doesn't return a list for Wasm since they rely on
    setSourceLineToBytecodePosition and therefore do not have that
    off-by-one error.
    
    Drive-by: Several elements have the same source position so update
    addHtmlElementToSourcePosition to handle more than one element.
    
    Drive-by: Renames due to having the same name but different
    capitalization, which was confusing.
    
    Bug: v8:7327
    Change-Id: Ie8a066ca629054a5f5a754deec0ed1917bed2b33
    Notry: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008634Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75655}
    433ff6b9
Name
Last commit
Last update
..
img Loading commit data...
src Loading commit data...
test Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
deploy.sh Loading commit data...
down-arrow.png Loading commit data...
index.html Loading commit data...
info-view.html Loading commit data...
left-arrow.png Loading commit data...
package-lock.json Loading commit data...
package.json Loading commit data...
right-arrow.png Loading commit data...
rollup.config.js Loading commit data...
search2.png Loading commit data...
tabs.css Loading commit data...
tsconfig.json Loading commit data...
tsconfig.test.json Loading commit data...
tsfmt.json Loading commit data...
tslint.json Loading commit data...
turbo-visualizer-ranges.css Loading commit data...
turbo-visualizer.css Loading commit data...
turbolizer.png Loading commit data...
up-arrow.png Loading commit data...
upload-icon.png Loading commit data...