• Ng Zhi An's avatar
    [wasm-simd][liftoff] Fix load from stack into reg for PrepareCall · 85990489
    Ng Zhi An authored
    Take care of the case when loading from stack slot into registers during
    PrepareCall. register_loads_ knows nothing of fp pair (it calls
    liftoff_code, which is nonsense for an fp pair), so we pass it dst.low().
    
    Earlier on in LoadStackSlot, we call load_dst_regs_.set(dst). This is
    implement to set both dst.low() and dst.high(). Later when we iterate
    over load_dst_regs_ (in ExecuteLoads), we special case loads of
    kWasmS128, and reconstruct a LiftoffRegister that is a fp pair (only
    when required), since LiftoffAssembler::Fill knows how to handle loading
    of s128 values. However, since we also set dst.high(), we will iterate
    over it too, but end up getting a RegisterLoad of nonsense values. This
    is not handled in the switch cases at all, so it works.
    
    Instead of this, we could transform a s128 load into two f64 load, and
    PrepareCall will be the only place that does this, since other callers
    of Fill will use kWasmS128. And we would have to do 2 loads instead of
    1 add and 1 load.
    
    Bug: v8:9909
    Change-Id: I20f69de48a650b457a199fde02c8e58641b2c176
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2013920Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65927}
    85990489
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...