• Victor Gomes's avatar
    [runtime] Refactor TransitionsAccessor · c927ada7
    Victor Gomes authored
    Problems:
    - The class uses a bare Map field, but some methods can trigger GC
    causing it to have a potential dangling pointer in case of map
    compaction.
    - Some methods invalidate the object state and should not be used again.
    - Complicate logic with a no_gc and a gc aware constructors. Some
    methods can only be called if the object is constructed with a
    particular constructor (e.g, Insert and PutPrototypeTransition).
    
    Note: Most usages of this class is done by constructing an object and
    calling a single method:
    `TransitionAccessor(...).Method(...)`
    So we can easily change them to a static method.
    
    This CL:
    1. Adds DISALLOW_GARBAGE_COLLECTION to the class.
    2. Makes methods that can trigger GC static.
    3. Creates static helper functions that wrap the class in a different
    scope, since TransitionsAccessor now forces the scope to disallow gc.
    4. Removes now unnecessary "Reload" logic.
    
    Bug: chromium:1295133, v8:12578
    Change-Id: I85484e7235fbd5e69894e26f5e1c491c6f69635e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3450416Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Victor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79051}
    c927ada7
Name
Last commit
Last update
..
benchmarks Loading commit data...
bigint Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
debugging Loading commit data...
fuzzer Loading commit data...
fuzzilli Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...