• Clemens Backes's avatar
    [liftoff][arm64] Fix address computation for trap handling · c8d60d7e
    Clemens Backes authored
    This refactors the {GetMemOp} function once again:
    Instead of computing (mem_start + (offset_reg + offset_imm)), do compute
    ((mem_start + offset_imm) + offset_reg). This avoids an overflow in
    (offset_reg + offset_imm) when using 32-bit computations, which hides
    OOB memory accesses when relying on the trap handler.
    
    As a nice side-effect, this change makes the whole method a lot nicer to
    read.
    
    We also need to change {StoreTaggedPointer} now, which was relying on the
    inner working of {GetMemOp}. The new version makes the semantics more
    transparent at the cost of repeating some logic from (the previous version
    of) {GetMemOp}.
    
    R=jkummerow@chromium.org
    
    Bug: v8:11955, chromium:1227465, v8:11951
    Change-Id: Ia068ca7c4f7db89b81529edd3438b0e4eee7d23d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3015566
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75693}
    c8d60d7e
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...