• Clemens Backes's avatar
    [liftoff][arm64] Fix address computation for trap handling · c8d60d7e
    Clemens Backes authored
    This refactors the {GetMemOp} function once again:
    Instead of computing (mem_start + (offset_reg + offset_imm)), do compute
    ((mem_start + offset_imm) + offset_reg). This avoids an overflow in
    (offset_reg + offset_imm) when using 32-bit computations, which hides
    OOB memory accesses when relying on the trap handler.
    
    As a nice side-effect, this change makes the whole method a lot nicer to
    read.
    
    We also need to change {StoreTaggedPointer} now, which was relying on the
    inner working of {GetMemOp}. The new version makes the semantics more
    transparent at the cost of repeating some logic from (the previous version
    of) {GetMemOp}.
    
    R=jkummerow@chromium.org
    
    Bug: v8:11955, chromium:1227465, v8:11951
    Change-Id: Ia068ca7c4f7db89b81529edd3438b0e4eee7d23d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3015566
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75693}
    c8d60d7e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...