• Dan Elphick's avatar
    [parser] Force stable order for variables · c8ab41eb
    Dan Elphick authored
    When parsing an arrowhead, it's possible for temporary variables to be
    created with a different index depending on whether the parsing is lazy
    or eager. This then results in bytecode mismatches as the index is used
    to determine which register to use.
    
    To make the ordering stable, this changes variable allocation in arrow
    functions to always allocate the non-temporaries first and then the
    temporaries.
    
    Bug: chromium:1020162
    Change-Id: Ia47c4c2916d63f12d20d663e4e3842bfd68f6d8e
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1977865
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65657}
    c8ab41eb
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...