• Daniel Bevenius's avatar
    [snapshot] enable mksnapshot usage to be displayed · c8679386
    Daniel Bevenius authored
    Currently, when specifying '--help' with mksnapshot it will only
    print the v8/d8 help message and options and then exit the process.
    This means that the usage message from mksnapshot will never be
    displayed.
    
    This commit suggests adding an option to SetFlagsFromCommandLine that
    can disable this printing and exiting. This allows mksnapshot to display
    the usage and print the options after that.
    
    While this works, it does seems a little strange that
    SetFlagsFromCommandLine prints the help message and exits the process
    but I'm probably missing some background details around this.
    
    Change-Id: I28932adf3478b88b05eed4db70bf74946f8abf2d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2290852Reviewed-by: 's avatarDan Elphick <delphick@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68851}
    c8679386
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...