• Ng Zhi An's avatar
    [tools] Fix lldb_commands jco by casting call · c8350144
    Ng Zhi An authored
    Currently, running jco gives us an error message like so:
    
    (lldb) jco $pc
    Failed to evaluate command _v8_internal_Print_Code((void*)($pc)) :
    error: <user expression 0>:1:1: '_v8_internal_Print_Code' has unknown
    return type; cast the call to its declared return type
    _v8_internal_Print_Code((void*)($pc))
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
    The fix is to cast the call to (void). I've only used and found this
    issue with jco, but I think the other commands have the same issue, so
    fixing those together here.
    
    FYI I am using lldb version 11.
    
    Bug: v8:11879
    Change-Id: Id9d8e8091fd011585e6fea863de5b4d7c9d47c5a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994764Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75487}
    c8350144
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...