• Anton Bikineev's avatar
    Handles: Fix OnStackTracedNodeSpace with -fsanitize=safe-stack · c7fbac6a
    Anton Bikineev authored
    When the stack is split in safe and unsafe parts, on-stack
    TracedReferences are allocated on the unsafe stack. What currently
    happens is that on GC we destroy all the on-stack references below the
    current frame of the *safe* stack. If the safe stack is allocated above
    the unsafe counterpart, then all the traced references will be
    preliminary destructed on GC. This CL fixes it by using
    __builtin___get_unsafe_stack_ptr() if -fsanitize=safe-stack is enabled.
    
    In addition, deduplicate OnStackTracedNodeSpace::IsOnStack() and
    Stack::IsOnStack() and move more logic into ::heap::base::Stack.
    
    Bug: chromium:1278780
    Change-Id: I9582bb1321958b7ec8ef2c0c46b9e42d51bb6f94
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3395033Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Anton Bikineev <bikineev@chromium.org>
    Auto-Submit: Anton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78660}
    c7fbac6a
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...