• Andreas Haas's avatar
    [wasm] Extract module compilation code into module-compiler.cc · c7892d35
    Andreas Haas authored
    This CL extracts the classes CompilationHelper, InstantiationHelper,
    and AsyncCompileJob from wasm-module.cc and puts them into
    module-compiler.{h|cc}. This is necessary to introduce a
    WasmCompilationManager which is known to the isolate and manages the
    lifetime of all AsyncCompileJobs.
    
    In addition to the mechanical changes of copying the code and splitting
    class declaration from instantiation, I did the following changes:
    
    * I renamed the CompilationHelper to ModuleCompiler.
    * A finalizer function is passed to the InstantiationHelper as a
      parameter.
    * Adjusted UpdateDispatchTable in wasm-module.cc to make it available in
      wasm-module.h, also with the internal signature.
    * Duplicate the ResolvePromise/RejectPromise helper functions.
    
    I did not rename InstantiationHelper because I could not come up with a
    good name, and it could benefit from a small special refactoring anyways.
    
    BUG=v8:6436
    R=clemensh@chromium.org, mtrofin@chromium.org
    
    Change-Id: I4abe854c36dfc995b34c9d7b3e7ec0f4f0aa562e
    Reviewed-on: https://chromium-review.googlesource.com/525572
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45773}
    c7892d35
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...