• Ross McIlroy's avatar
    Revert "Reland "[builtins] Embed builtins into the binary"" · c75ff739
    Ross McIlroy authored
    This reverts commit 75d19b5b.
    
    Reason for revert: Breaking Mac: https://build.chromium.org/p/client.v8.fyi/builders/Mac%20V8%20FYI%20Release%20%28Intel%29/builds/290
    
    Original change's description:
    > Reland "[builtins] Embed builtins into the binary"
    > 
    > This is a reland of 491d5a81
    > 
    > Original change's description:
    > > [builtins] Embed builtins into the binary
    > >
    > > This embeds code for off-heap-safe builtins into the binary. Actual
    > > execution of embedded code is not implemented yet.
    > >
    > > The embedded file has the following format:
    > >
    > > namespace v8 {
    > > namespace internal {
    > >
    > > namespace {
    > >
    > > V8_EMBEDDED_TEXT_HEADER(v8_embedded_blob_)
    > > __asm__( /* builtin offsets and lengths */ );
    > > __asm__(V8_ASM_LABEL("Builtins_RecordWrite"));
    > > __asm__( /* binary instruction stream */ );
    > > /* Repeat for other builtins. */
    > >
    > > extern "C" const uint8_t v8_embedded_blob_[];
    > > static const uint32_t v8_embedded_blob_size_ = /* size in bytes */;
    > >
    > > }  // namespace
    > >
    > > const uint8_t* DefaultEmbeddedBlob() { return v8_embedded_blob_; }
    > > uint32_t DefaultEmbeddedBlobSize() { return v8_embedded_blob_size_; }
    > >
    > > }  // namespace internal
    > > }  // namespace v8
    > >
    > > Bug: v8:6666
    > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng
    > > Change-Id: Ic989f01da69ebe2863f31d934bfbe2c5d6e80864
    > > Reviewed-on: https://chromium-review.googlesource.com/946011
    > > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#51759}
    > 
    > TBR=yangguo@chromium.org
    > 
    > Bug: v8:6666
    > Change-Id: Iba245976ce46c62474dcba94a99ab4a217b2e20e
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng
    > Reviewed-on: https://chromium-review.googlesource.com/950983
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51769}
    
    TBR=yangguo@chromium.org,jgruber@chromium.org
    
    Change-Id: If2560e5ea57585421ba5c3da35717abb9b31766f
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:6666
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux64_fyi_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/951562Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51772}
    c75ff739
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...