• Sathya Gunasekaran's avatar
    [intl] Cache the last used formatter if possible · 4b139f76
    Sathya Gunasekaran authored
    Instead of caching only the default formatter, cache the last used
    formatter if possible.
    
    This is better because it's a common use case to create a formatter
    in a different language and reuse it a lot, rather than create
    several formatters in various languages.
    
    Running the following benchmark:
    ```
    let i = 0;
    
    function toLocaleString() {
      i++;
      return i.toLocaleString();
    }
    
    i = 0;
    function toLocaleStringWithLocale() {
      i++;
      return i.toLocaleString('en-US');
    }
    
    const functions = [toLocaleString, toLocaleStringWithLocale];
    
    for (const f of functions) {
      let start = performance.now();
      for (let i = 0; i < 10e5; i++) {
        f();
      }
      let end = performance.now();
      print(`${f.name}: ${end - start}`);
    }
    ```
    sees the following improvements:
    
    With this patch:
      toLocaleString: 384.292
      toLocaleStringWithLocale: 450.48900000000003
    
    Without this patch:
      toLocaleString: 341.952
      toLocaleStringWithLocale: 23439.694
    
    This a little over 50x improvement.
    
    Bug: chromium:926075
    Change-Id: I0e316e959c90243e175df985854832a7abddbf54
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2536461
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71188}
    4b139f76
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
arguments-inl.h Loading commit data...
arguments.cc Loading commit data...
arguments.h Loading commit data...
execution.cc Loading commit data...
execution.h Loading commit data...
external-pointer-table.cc Loading commit data...
external-pointer-table.h Loading commit data...
frame-constants.h Loading commit data...
frames-inl.h Loading commit data...
frames.cc Loading commit data...
frames.h Loading commit data...
futex-emulation.cc Loading commit data...
futex-emulation.h Loading commit data...
interrupts-scope.cc Loading commit data...
interrupts-scope.h Loading commit data...
isolate-data.h Loading commit data...
isolate-inl.h Loading commit data...
isolate-utils-inl.h Loading commit data...
isolate-utils.h Loading commit data...
isolate.cc Loading commit data...
isolate.h Loading commit data...
local-isolate-inl.h Loading commit data...
local-isolate.cc Loading commit data...
local-isolate.h Loading commit data...
messages.cc Loading commit data...
messages.h Loading commit data...
microtask-queue.cc Loading commit data...
microtask-queue.h Loading commit data...
pointer-authentication-dummy.h Loading commit data...
pointer-authentication.h Loading commit data...
protectors-inl.h Loading commit data...
protectors.cc Loading commit data...
protectors.h Loading commit data...
runtime-profiler.cc Loading commit data...
runtime-profiler.h Loading commit data...
simulator-base.cc Loading commit data...
simulator-base.h Loading commit data...
simulator.h Loading commit data...
stack-guard.cc Loading commit data...
stack-guard.h Loading commit data...
thread-id.cc Loading commit data...
thread-id.h Loading commit data...
thread-local-top.cc Loading commit data...
thread-local-top.h Loading commit data...
v8threads.cc Loading commit data...
v8threads.h Loading commit data...
vm-state-inl.h Loading commit data...
vm-state.h Loading commit data...