• vogelheim's avatar
    Scanner::LiteralBuffer usage cleanup. · c677f813
    vogelheim authored
    1, restrict use of LiteralBuffers to the tokens that actually need it.
      - E.g., previously the Token::FUNCTION would have a literal buffer
        containing "function", which was never actually used.
      - This eliminates copies of the string data for every call to
        PeekAhead or SetBookmark.
    2, document & enforce the "secret" Scanner API contract w/ DCHECK
      - Document & check the correspondence of token value and literal buffer.
      - Document & check preconditions for calling PeekAhead, ScanRegExp*,
        ScanTemplate*.
    
    BUG=v8:4947
    
    Review-Url: https://codereview.chromium.org/2240513003
    Cr-Commit-Position: refs/heads/master@{#38677}
    c677f813
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...