• Clemens Backes's avatar
    [wasm][debug] Only patch a single frame for stepping · c66cd826
    Clemens Backes authored
    Stepping only happens in one frame at a time, so we don't need to
    rewrite the whole stack. This allows us to remove the
    {flooded_function_index_}, since no function is globally flooded any
    more.
    A follow-up CL will ensure that the code will also not be installed in
    the code table and jump table any more, to fix issues with non-local
    control flow (i.e. catching a trap and reentering wasm), where we
    could currently accidentally execute flooded code. It will also speed
    up stepping over recursive calls enormously, since the recursive calls
    don't run into the flooded breakpoints any more.
    
    R=thibaudm@chromium.org
    
    Bug: v8:10235
    Change-Id: Ifae5e35c3242c95e1fe1a89a169ce874b818a288
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2152646Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67202}
    c66cd826
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...