• Peter Marshall's avatar
    [cleanup] Clean up InstallFunction variants in the bootstrapper · c65712e1
    Peter Marshall authored
    - Remove an unused param from InstallFunction
    - Remove an InstallFunction variant which just rearranges the order of
      the arguments
    - Consistently use const char* string literals as property names rather
      than e.g. factory->return_string() just write "return" because it is
      easier for humans to read. All the strings are internalized anyway and
      this happens at mksnapshot time, so there is no performance penalty.
    - Remove the maybe_prototype arguments to CreateFunction. We always know
      at the callsite whether we have a prototype or not, so just call the
      variant that takes a prototype or the new CreateFunction variant which
      takes a Builtin::name.
    - Rename a SimpleInstallFunction variant which was only used for symbols
      to InstallFunctionAtSymbol. This also makes it clear that this is the
      only case where property_name and function_name differ.
    
    Bug: v8:8238
    Change-Id: I2400de90ebe837694e777cff1419858037ee51cc
    Reviewed-on: https://chromium-review.googlesource.com/c/1349271Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57769}
    c65712e1
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...