• Hai Dang's avatar
    Fix typing of binary operators on BigInt. · c5c6b8bc
    Hai Dang authored
    BinaryNumberOpTyper was not monotonic: if one input changes
    from Number to Numeric, while the other input stays BigInt,
    the result would change from Number to BigInt.
    
    We have some fuzzing tests for monotonicity but unfortunately
    they never generated the inputs required for triggering this bug.
    We'll look into improving our tests.
    
    Bug: v8:8380
    Change-Id: I7320d9ae4b89ad8798bf9e97cc272edba2162a77
    Reviewed-on: https://chromium-review.googlesource.com/c/1307418
    Commit-Queue: Hai Dang <dhai@google.com>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57125}
    c5c6b8bc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...