• Jakob Gruber's avatar
    [code] Move the unwinding info into metadata area · c5379162
    Jakob Gruber authored
    Semantically, the unwinding info is a variable-size metadata table
    with untagged (i.e. no relocation needed) contents, packed inside Code
    objects. This is just like other metadata tables (safepoint table,
    handler table, constant pool, code comments); but for historical
    reasons it's been treated differently so far. Unlike these other
    tables, the unwinding info was located *after* InstructionEnd, and its
    size was written to the first 8 bytes after InstructionEnd.
    
    This CL makes unwinding info handling more consistent with other
    metadata tables by writing its offset into a dedicated
    kUnwindingInfoOffsetOffset header slot, and by moving the actual data
    inside the [InstructionStart,InstructionEnd[ area. In follow-up CLs,
    this area will be split into dedicated instruction- and metadata
    areas.
    
    A picture is worth 1000 words, before:
    
     +--------------------------+  <-- raw_instruction_start()
     |       instructions       |
     |           ...            |
     +--------------------------+
     |     embedded metadata    |  <-- safepoint_table_offset()
     |           ...            |  <-- handler_table_offset()
     |                          |  <-- constant_pool_offset()
     |                          |  <-- code_comments_offset()
     |    padding to the next   |
     |  8-byte aligned address  |
     +--------------------------+  <-- raw_instruction_end()
     |   [unwinding_info_size]  |
     |        as uint64_t       |
     +--------------------------+  <-- unwinding_info_start()
     |       unwinding info     |
     |            ...           |
     +--------------------------+  <-- unwinding_info_end()
    
    After:
    
     +--------------------------+  <-- raw_instruction_start()
     |       instructions       |
     |           ...            |
     +--------------------------+
     |     embedded metadata    |  <-- safepoint_table_offset()
     |           ...            |  <-- handler_table_offset()
     |                          |  <-- constant_pool_offset()
     |                          |  <-- code_comments_offset()
     |                          |  <-- unwinding_info_offset()
     |                          |
     +--------------------------+  <-- raw_instruction_end()
    
    Bug: v8:11036
    Change-Id: I649708821acc5365186ca2c9cff2669fc3e91fd3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2484795Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70640}
    c5379162
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...