• Philip Pfaffe's avatar
    Improve iterator_range to take non-&& arguments · c51c9f7c
    Philip Pfaffe authored
    The current implementation takes forwarding reference arguments, which
    is fine when you call it with rvalues, like
    make_iterator_range(V.begin(), V.end()). If you call it with lvalues
    though, it doesn't do what you'd expect. ForwardIterator becomes a
    reference:
    
    Foo I = V.begin();
    make_iterator_range(I, I); //ForwardIterator is deduced as Foo&
    
    Since iterator are supposed to be small, no harm in passing them by
    value.
    
    Change-Id: I151c87304949d810c72c42f60e9d1a7151f61f83
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020780
    Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66007}
    c51c9f7c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...