• Benedikt Meurer's avatar
    [turbofan] Propagate kIdentifyZeros correctly for modulus. · c4ada3de
    Benedikt Meurer authored
    For NumberModulus and SpeculativeNumberModulus there's no observable
    difference between 0 and -0 for the right hand side, since both of them
    result in NaN (in general the sign of the right hand side is ignored
    for modulus in JavaScript). For the left hand side we can just propagate
    the zero identification part of the truncation, since we only care about
    -0 on the left hand side if the use nodes care about -0 too.
    
    This further improves the Kraken/audio-oscillator test from around 67ms
    to 64ms.
    
    Bug: v8:8015, v8:8178
    Change-Id: I1f51d42f7df08aaa28a9b0ddd3177df6b76be98c
    Reviewed-on: https://chromium-review.googlesource.com/c/1260024
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56372}
    c4ada3de
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...