• Thibaud Michaud's avatar
    [regalloc] Fix slow edge case in BuildBundles · c46c1957
    Thibaud Michaud authored
    The issue is with this pattern, assuming disjoint uses for all vregs:
    
    phi: v1 = v0 ...
    phi: v2 = v0 ...
    phi: v3 = v0 ...
    ...
    phi: vN = v0 ...
    
    For every phi, BuildBundles proceeds as follows:
    - Create a new bundle for the output
    - Merge the input bundle into the output bundle
    
    Since the bundle gets bigger at every iteration, the merges become more
    and more expensive and consume Zone memory that is immediately thrown
    away at the next iteration.
    
    A simple fix is to check the size of the bundles before merging and
    always copy the smallest one into the biggest. In the pattern above this
    should always copy the single-range output bundle into the large input
    bundle.
    
    R=sigurds@chromium.org
    
    Bug: v8:11237
    Change-Id: I6ad9152035da698d94b02b5b41802545ba149307
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2584879Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Thibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71714}
    c46c1957
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...