• Brendan Shanks's avatar
    Use NtCurrentTeb() in GetStackStart() to fix 64-bit Wine on macOS · c40c8f7d
    Brendan Shanks authored
    When running 64-bit Windows binaries on macOS using Wine, there is a
    conflict between macOS's use of GS to point to pthread thread-specific
    data, and Windows' use of GS to point to the TEB.
    
    Apple has reserved some TSD slots for use by Wine to store commonly-used
    TEB members (such as 0x30, the 'Self' pointer to the TEB).
    But, other direct GS accesses by Windows programs (such as to
    'StackBase') will return macOS pthread data rather than the TEB member.
    This was causing a V8 unit test to crash on macOS under Wine.
    
    Using NtCurrentTeb() gets the 'Self' pointer first, then dereferences
    it to access the correct 'StackBase', fixing the crash.
    This turns GetStackStart() from one instruction into two.
    
    Chrome (http://crrev.com/c/2380425) and Crashpad also use
    NtCurrentTeb().
    
    The 32-bit change isn't needed, but is just for consistency.
    
    Bug: chromium:1121842
    Change-Id: I824f893aa451d8570142226be91840c964426f38
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2381941Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69627}
    c40c8f7d
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...