• Brendan Shanks's avatar
    Use NtCurrentTeb() in GetStackStart() to fix 64-bit Wine on macOS · c40c8f7d
    Brendan Shanks authored
    When running 64-bit Windows binaries on macOS using Wine, there is a
    conflict between macOS's use of GS to point to pthread thread-specific
    data, and Windows' use of GS to point to the TEB.
    
    Apple has reserved some TSD slots for use by Wine to store commonly-used
    TEB members (such as 0x30, the 'Self' pointer to the TEB).
    But, other direct GS accesses by Windows programs (such as to
    'StackBase') will return macOS pthread data rather than the TEB member.
    This was causing a V8 unit test to crash on macOS under Wine.
    
    Using NtCurrentTeb() gets the 'Self' pointer first, then dereferences
    it to access the correct 'StackBase', fixing the crash.
    This turns GetStackStart() from one instruction into two.
    
    Chrome (http://crrev.com/c/2380425) and Crashpad also use
    NtCurrentTeb().
    
    The 32-bit change isn't needed, but is just for consistency.
    
    Bug: chromium:1121842
    Change-Id: I824f893aa451d8570142226be91840c964426f38
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2381941Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69627}
    c40c8f7d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...