• Milad Farazmand's avatar
    PPC/s390: [Liftoff] Improve initialization for many locals · c314cf74
    Milad Farazmand authored
    Port a8cdda99
    
    Original Commit Message:
    
        WebAssembly locals are specified to be zero on function entry. Liftoff
        implements this by just storing the constant 0 in the virtual stack for
        integer types, and using one floating point register initialized to
        zero for all floating point types.
        For big counts of locals this leads to problems (manifesting as huge
        blocks of code being generated) once we hit a merge point: All those
        constants (for int) and all duplicate register uses (for floats) need to
        be fixed up, by using separate registers for the locals or spilling to
        the stack if no more registers are available. All this spilling
        generates a lot of code, and can even happen multiple times within a
        function.
    
        This CL optimizes for such cases by spilling all locals to the stack
        initially. All merges within the function body get much smaller then.
        The spilled values rarely have to be loaded anyway, because the initial
        zero value is usually overwritten before the first use.
    
        To optimize the code size for initializing big numbers of locals on the
        stack, this CL also introduces the platform-specific
        {FillStackSlotsWithZero} method which uses a loop for bigger local
        counts.
    
        This often saves dozens of kilobytes for very big functions, and shows
        an overall code size reduction of 4-5 percent for big modules.
    
    R=clemensb@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N
    
    Change-Id: I2459080a1f6acfdd212e9a93a868d028980c5554
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1863370Reviewed-by: 's avatarJunliang Yan <jyan@ca.ibm.com>
    Reviewed-by: 's avatarMilad Farazmand <miladfar@ca.ibm.com>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#64301}
    c314cf74
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...