• Michael Lippautz's avatar
    cppgc: Check for correct base class inheritance · 143e6a74
    Michael Lippautz authored
    The only valid way to define a GCed type T is by inheriting from
    GarbageCollected<T>. Since this is prone to typos (see tests), add a
    simple check that covers most interesting use cases.
    
    The static assert covers
      A -> B -> GarbageCollected<C>
    
    The static assert does not cover
     A -> B -> C -> GarbageCollected<B>
    
    (In order to do so, we would need __direct_bases() support which is
    not yet available for C++.)
    
    Bug: pdfium:1670, chromium:1056170
    Change-Id: I494de48992f8ba9a1f0f9daad60584d828717403
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810415Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73854}
    143e6a74
Name
Last commit
Last update
..
compactor-unittest.cc Loading commit data...
concurrent-marking-unittest.cc Loading commit data...
concurrent-sweeper-unittest.cc Loading commit data...
cross-thread-persistent-unittest.cc Loading commit data...
custom-spaces-unittest.cc Loading commit data...
ephemeron-pair-unittest.cc Loading commit data...
explicit-management-unittest.cc Loading commit data...
finalizer-trait-unittest.cc Loading commit data...
free-list-unittest.cc Loading commit data...
garbage-collected-unittest.cc Loading commit data...
gc-info-unittest.cc Loading commit data...
gc-invoker-unittest.cc Loading commit data...
heap-growing-unittest.cc Loading commit data...
heap-object-header-unittest.cc Loading commit data...
heap-page-unittest.cc Loading commit data...
heap-statistics-collector-unittest.cc Loading commit data...
heap-unittest.cc Loading commit data...
incremental-marking-schedule-unittest.cc Loading commit data...
logging-unittest.cc Loading commit data...
marker-unittest.cc Loading commit data...
marking-verifier-unittest.cc Loading commit data...
marking-visitor-unittest.cc Loading commit data...
member-unittest.cc Loading commit data...
metric-recorder-unittest.cc Loading commit data...
minor-gc-unittest.cc Loading commit data...
name-trait-unittest.cc Loading commit data...
object-size-trait-unittest.cc Loading commit data...
object-start-bitmap-unittest.cc Loading commit data...
page-memory-unittest.cc Loading commit data...
persistent-family-unittest.cc Loading commit data...
prefinalizer-unittest.cc Loading commit data...
run-all-unittests.cc Loading commit data...
source-location-unittest.cc Loading commit data...
stack-unittest.cc Loading commit data...
stats-collector-scopes-unittest.cc Loading commit data...
stats-collector-unittest.cc Loading commit data...
sweeper-unittest.cc Loading commit data...
test-platform.cc Loading commit data...
test-platform.h Loading commit data...
testing-unittest.cc Loading commit data...
tests.cc Loading commit data...
tests.h Loading commit data...
visitor-unittest.cc Loading commit data...
weak-container-unittest.cc Loading commit data...
write-barrier-unittest.cc Loading commit data...