• Michael Lippautz's avatar
    cppgc: Check for correct base class inheritance · 143e6a74
    Michael Lippautz authored
    The only valid way to define a GCed type T is by inheriting from
    GarbageCollected<T>. Since this is prone to typos (see tests), add a
    simple check that covers most interesting use cases.
    
    The static assert covers
      A -> B -> GarbageCollected<C>
    
    The static assert does not cover
     A -> B -> C -> GarbageCollected<B>
    
    (In order to do so, we would need __direct_bases() support which is
    not yet available for C++.)
    
    Bug: pdfium:1670, chromium:1056170
    Change-Id: I494de48992f8ba9a1f0f9daad60584d828717403
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2810415Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73854}
    143e6a74
Name
Last commit
Last update
..
base Loading commit data...
cppgc Loading commit data...
allocation-observer-unittest.cc Loading commit data...
barrier-unittest.cc Loading commit data...
bitmap-test-utils.h Loading commit data...
bitmap-unittest.cc Loading commit data...
code-object-registry-unittest.cc Loading commit data...
embedder-tracing-unittest.cc Loading commit data...
gc-idle-time-handler-unittest.cc Loading commit data...
gc-tracer-unittest.cc Loading commit data...
heap-controller-unittest.cc Loading commit data...
heap-unittest.cc Loading commit data...
heap-utils.cc Loading commit data...
heap-utils.h Loading commit data...
index-generator-unittest.cc Loading commit data...
list-unittest.cc Loading commit data...
local-factory-unittest.cc Loading commit data...
local-heap-unittest.cc Loading commit data...
marking-unittest.cc Loading commit data...
marking-worklist-unittest.cc Loading commit data...
memory-reducer-unittest.cc Loading commit data...
object-start-bitmap-unittest.cc Loading commit data...
object-stats-unittest.cc Loading commit data...
persistent-handles-unittest.cc Loading commit data...
safepoint-unittest.cc Loading commit data...
slot-set-unittest.cc Loading commit data...
spaces-unittest.cc Loading commit data...
traced-reference-unittest.cc Loading commit data...
unified-heap-snapshot-unittest.cc Loading commit data...
unified-heap-unittest.cc Loading commit data...
unified-heap-utils.cc Loading commit data...
unified-heap-utils.h Loading commit data...
unmapper-unittest.cc Loading commit data...
worklist-unittest.cc Loading commit data...