• jgruber's avatar
    [regexp] Correct lastIndex behavior in RegExp.prototype[@@replace] · c0fe56e6
    jgruber authored
    @@replace has a pretty complex implementation, taking different paths
    for various situations (e.g.: global/nonglobal regexp, functional/string
    replace argument, etc.). Each of these paths must implement similar
    logic for calling into the RegExpBuiltinExec spec operation, and many
    paths get this subtly wrong.
    
    This CL fixes a couple of issues related to the way @@replace handles lastIndex:
    * All paths now respect lastIndex when calling into exec (some used to assume 0).
    * lastIndex is now advanced after a successful match for sticky regexps.
    * lastIndex is now only reset to 0 on failure for sticky regexps.
    
    BUG=v8:5361
    
    Review-Url: https://codereview.chromium.org/2685183003
    Cr-Commit-Position: refs/heads/master@{#43234}
    c0fe56e6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...